[#COR-1153] [Linq] Enum comparisons are not optimized

db4o Core

[Linq] Enum comparisons are not optimized

Created: 12/Feb/08 12:09 PM Updated: 27/May/08 03:30 PM

Component/s:

Linq

Affects Version/s:

None

Fix Version/s:

None

Time Tracking:

Original Estimate:

Not Specified

Remaining Estimate:

Not Specified

Time Spent:

8.22h

Issue Links:

Related

This issue is related to:

~~COR-1291~~ Backport "[Linq] Enum comparisons are not optimized" to 7.2

Order:	3
Iteration:	43
Original IDS Estimate:	3
Resolution Date:	20/May/08 01:26 PM
First Response Date:	15/May/08 06:02 AM
Labels:
Participants:	Adriano Verona and Rodrigo B. de Oliveira
Number of Attachments:	0
Number of Comments:	1

All

Comments

Work Log

Change History

Sort Order:

Ascending order - Click to sort in descending order

[ Permlink | « Hide ]

Adriano Verona - 15/May/08 06:02 AM

from the meeting:

[14/5/2008 12:26:50] Carl Rosenberger says: For QBE 0 is not respected.
[14/5/2008 12:27:15] Carl Rosenberger says: But there was something around not being able to use 0.
[14/5/2008 12:27:20] Carl Rosenberger says: That's a bug.
[14/5/2008 12:27:33] Carl Rosenberger says: Here is the nicest way to go:
[14/5/2008 12:27:44] Carl Rosenberger says: Have a different TypeHandler for enums.
[14/5/2008 12:28:05] Carl Rosenberger says: Just store the constant.
[14/5/2008 12:28:13] Rodrigo B. de Oliveira says: Carl, yes
[14/5/2008 12:28:33] Carl Rosenberger says: Writing a TypeHanler is easy.
[14/5/2008 12:28:50] Rodrigo B. de Oliveira says: maybe now
[14/5/2008 12:28:52] Rodrigo B. de Oliveira says: ?
[14/5/2008 12:29:15] Rodrigo B. de Oliveira says: cool
[14/5/2008 12:29:52] Rodrigo B. de Oliveira says: remember enums can have different integer representations
[14/5/2008 12:31:31] Rodrigo B. de Oliveira says: we could store the name and value
[14/5/2008 12:31:36] Rodrigo B. de Oliveira says: and throw if they don't match
[14/5/2008 12:32:34] Rodrigo B. de Oliveira says: enum is like a mapping from names to integer values
[14/5/2008 12:34:21] Rodrigo B. de Oliveira says: java enums are different
[14/5/2008 12:34:34] Rodrigo B. de Oliveira says: no integer semantics
[14/5/2008 12:35:29] Rodrigo B. de Oliveira says: they are just assumed to be static singletons?
[14/5/2008 12:35:42] Rodrigo B. de Oliveira says: ok
[14/5/2008 12:36:24] Rodrigo B. de Oliveira says: then we can use the same logic for java and .net
[14/5/2008 12:36:26] Rodrigo B. de Oliveira says: using only names
[14/5/2008 12:36:57] Rodrigo B. de Oliveira says: refactoring api?
[14/5/2008 12:37:04] Rodrigo B. de Oliveira says: when enum names are refactored, I mean
[14/5/2008 12:37:12] Rodrigo B. de Oliveira says: what happens?
[14/5/2008 12:38:54] Rodrigo B. de Oliveira says: that's an interesting documentation issue
[14/5/2008 12:39:04] Rodrigo B. de Oliveira says: "How do I refactor my enums?"
[14/5/2008 12:39:15] Tetyana says: should I note it in my tasks?
[14/5/2008 12:39:30] Rodrigo B. de Oliveira says: it would be interesting, yes
[14/5/2008 12:39:51] Carl Rosenberger says: Right now I think you can call #bind() again by hand to override default behaviour.

[ Show » ]

Adriano Verona - 15/May/08 06:02 AM from the meeting: [14/5/2008 12:26:50] Carl Rosenberger says: For QBE 0 is not respected. [14/5/2008 12:27:15] Carl Rosenberger says: But there was something around not being able to use 0. [14/5/2008 12:27:20] Carl Rosenberger says: That's a bug. [14/5/2008 12:27:33] Carl Rosenberger says: Here is the nicest way to go: [14/5/2008 12:27:44] Carl Rosenberger says: Have a different TypeHandler for enums. [14/5/2008 12:28:05] Carl Rosenberger says: Just store the constant. [14/5/2008 12:28:13] Rodrigo B. de Oliveira says: Carl, yes [14/5/2008 12:28:33] Carl Rosenberger says: Writing a TypeHanler is easy. [14/5/2008 12:28:50] Rodrigo B. de Oliveira says: maybe now [14/5/2008 12:28:52] Rodrigo B. de Oliveira says: ? [14/5/2008 12:29:15] Rodrigo B. de Oliveira says: cool [14/5/2008 12:29:52] Rodrigo B. de Oliveira says: remember enums can have different integer representations [14/5/2008 12:31:31] Rodrigo B. de Oliveira says: we could store the name and value [14/5/2008 12:31:36] Rodrigo B. de Oliveira says: and throw if they don't match [14/5/2008 12:32:34] Rodrigo B. de Oliveira says: enum is like a mapping from names to integer values [14/5/2008 12:34:21] Rodrigo B. de Oliveira says: java enums are different [14/5/2008 12:34:34] Rodrigo B. de Oliveira says: no integer semantics [14/5/2008 12:35:29] Rodrigo B. de Oliveira says: they are just assumed to be static singletons? [14/5/2008 12:35:42] Rodrigo B. de Oliveira says: ok [14/5/2008 12:36:24] Rodrigo B. de Oliveira says: then we can use the same logic for java and .net [14/5/2008 12:36:26] Rodrigo B. de Oliveira says: using only names [14/5/2008 12:36:57] Rodrigo B. de Oliveira says: refactoring api? [14/5/2008 12:37:04] Rodrigo B. de Oliveira says: when enum names are refactored, I mean [14/5/2008 12:37:12] Rodrigo B. de Oliveira says: what happens? [14/5/2008 12:38:54] Rodrigo B. de Oliveira says: that's an interesting documentation issue [14/5/2008 12:39:04] Rodrigo B. de Oliveira says: "How do I refactor my enums?" [14/5/2008 12:39:15] Tetyana says: should I note it in my tasks? [14/5/2008 12:39:30] Rodrigo B. de Oliveira says: it would be interesting, yes [14/5/2008 12:39:51] Carl Rosenberger says: Right now I think you can call #bind() again by hand to override default behaviour.